----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12831/#review23862 -----------------------------------------------------------
Ship it! Ship It! - Ben Mahler On July 23, 2013, 2:14 a.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12831/ > ----------------------------------------------------------- > > (Updated July 23, 2013, 2:14 a.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Prefer "ng-show" to jQuery accessors > > The loading GIF can be shown/hidden based on a scope variable without > involving jQuery (down w/ jQuery). > > "#navbar" is never hidden, and so the "show()" call was unneeded. > > > Diffs > ----- > > src/webui/master/static/index.html 296547abc5c5837632df838596a453c837973964 > src/webui/master/static/js/controllers.js > dae12b61001ff0c7379169242e5d125ef6ca141b > > Diff: https://reviews.apache.org/r/12831/diff/ > > > Testing > ------- > > > Thanks, > > Ross Allen > >
