----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12888/#review23866 -----------------------------------------------------------
Ship it! Ship It! - Ben Mahler On July 24, 2013, 12:12 a.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12888/ > ----------------------------------------------------------- > > (Updated July 24, 2013, 12:12 a.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Remove 'ui-if' direction in favor of 'ng-show' > > Angular provides 'ng-show' to hide elements when not needed. They are > rendered in the DOM unlike with 'ui-if', but using native Angular > prevents needing outside code or dependencies for a directive used in > only one template. > > > Diffs > ----- > > src/webui/master/static/browse.html > 366e99978554916feb7be962d4f1df8fd93773cc > src/webui/master/static/js/app.js dd56a23b28c11dc0882f6cb07c0eb159ae600614 > > Diff: https://reviews.apache.org/r/12888/diff/ > > > Testing > ------- > > Rendered /browse to validate elements were shown/hidden at proper times. > > > Thanks, > > Ross Allen > >
