----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12879/#review23873 -----------------------------------------------------------
src/webui/master/static/js/controllers.js <https://reviews.apache.org/r/12879/#comment47693> Can you move these down to where they're used? - Ben Mahler On July 23, 2013, 8:52 p.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12879/ > ----------------------------------------------------------- > > (Updated July 23, 2013, 8:52 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Search frameworks & executors successively to save concat > > Array.concat creates a new Array, which in this case is used once to > find frameworks and executors and then thrown away. Instead the Arrays > can be searched successively in place without allocating more memory. > > > Diffs > ----- > > src/webui/master/static/js/controllers.js > dae12b61001ff0c7379169242e5d125ef6ca141b > > Diff: https://reviews.apache.org/r/12879/diff/ > > > Testing > ------- > > Rendered SlaveExecutor page to verify output didn't change with this commit. > > > Thanks, > > Ross Allen > >
