----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12880/#review23874 -----------------------------------------------------------
src/webui/master/static/js/controllers.js <https://reviews.apache.org/r/12880/#comment47694> Can you move this down to where it's used? - Ben Mahler On July 23, 2013, 8:54 p.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12880/ > ----------------------------------------------------------- > > (Updated July 23, 2013, 8:54 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Compute framework stats in one iteration > > Rather than iterate over 'frameworks' and 'completed_frameworks' once > to update the slave mappings and a second time to calculate stats for > the frameworks, move that work into a single loop. > > This also removes a 'concat' call that was creating a temporary Array > used to calculate stats once and then thrown away. > > > Diffs > ----- > > src/webui/master/static/js/controllers.js > dae12b61001ff0c7379169242e5d125ef6ca141b > > Diff: https://reviews.apache.org/r/12880/diff/ > > > Testing > ------- > > Rendered /slaves/:id to verify framework stats were still calculated properly. > > > Thanks, > > Ross Allen > >
