----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12959/#review23889 -----------------------------------------------------------
Ship it! hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java <https://reviews.apache.org/r/12959/#comment47714> How about something like the following to be more explicit about what was going wrong: "It appears that pendingMaps() and pendingReduces do not return the values we expect. We've observed negative values (possibly related to: https://issues.apache.org/jira/browse/MAPREDUCE-1238). Below is the ..." - Ben Mahler On July 25, 2013, 11:16 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12959/ > ----------------------------------------------------------- > > (Updated July 25, 2013, 11:16 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Fixed comment for Hadoop pending tasks calculation. > > The commit 58e6c907497418d was submitted prematurely without this > comment. > > > Diffs > ----- > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java > d9a9dbb57b10a8450ef8d822a041fa8d716bae4c > > Diff: https://reviews.apache.org/r/12959/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Brenden Matthews > >
