----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12951/#review24247 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp <https://reviews.apache.org/r/12951/#comment48055> Yes, my intuition tells me we'll want to omit them if not present. - Benjamin Hindman On July 25, 2013, 10:05 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12951/ > ----------------------------------------------------------- > > (Updated July 25, 2013, 10:05 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > JSON::Number was output using a precision of 10 digits, whereas double > precision guarantees 15 digits of accuracy. > > Digits 16 and 17 may be bogus, so kept it at 15. See: > http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2006/n2005.pdf > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp > e2ef0d3a50e698192ba182d53dbcc9186542df06 > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > bd5bc7372fafb1aba757ac08acceeb9689e2fc09 > 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp > c582d7084747f4f1804cc554cc544c8bc02602ac > > Diff: https://reviews.apache.org/r/12951/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
