----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12621/#review24249 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/src/tests/process_tests.cpp <https://reviews.apache.org/r/12621/#comment48056> Consider creating the temporary file in the test and passing it in (likewise deleting it from within the test). - Benjamin Hindman On July 17, 2013, 1:50 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12621/ > ----------------------------------------------------------- > > (Updated July 17, 2013, 1:50 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See above. This exercises the sendfile code in libprocess. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/process_tests.cpp > dfa11df4b5eaa8116d7150feea67bb255d3389de > > Diff: https://reviews.apache.org/r/12621/diff/ > > > Testing > ------- > > ./3rdparty/libprocess/tests --gtest_filter="Process.provide" > --gtest_repeat=30000 --gtest_break_on_failure > > > Thanks, > > Ben Mahler > >
