----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13036/#review24264 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On July 29, 2013, 10:02 p.m., Eric Biederman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13036/ > ----------------------------------------------------------- > > (Updated July 29, 2013, 10:02 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, and Vinod > Kone. > > > Repository: mesos > > > Description > ------- > > src/slave/paths: Fully qualify references to ::fs::symlink > > If paths.hpp is included in the same file with src/linux/fs.hpp > fs::symlink will be search for in ::mesos::internal::fs instead > of in ::fs and as a result will not be found. > > Fix this by changing refernces to fs:symlink to ::fs::symlink so > there is no ambiguity of about where to find the code. > > This comes up in practice when extending cgroup_isolator.cpp > to support some of the more interesting namespace features. > > > Diffs > ----- > > src/slave/paths.hpp 9d2a2a4 > > Diff: https://reviews.apache.org/r/13036/diff/ > > > Testing > ------- > > make -j8 check > > The code builds and the tests pass. > > > Thanks, > > Eric Biederman > >
