> On July 26, 2013, 12:41 a.m., Ben Mahler wrote: > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java, lines > > 362-367 > > <https://reviews.apache.org/r/12921/diff/2/?file=327721#file327721line362> > > > > It seems like the goal of the minimum here is to have a minimum amount > > of idle slots in the cluster? If so, we should likely update the > > configuration names to be: > > > > mapred.mesos.total.idle.map.slots.minimum > > mapred.mesos.total.idle.reduce.slots.minimum
It's not the minimum idle slots. If I have a minimum of 100, but I have 10 idle slots, I still need 90 slots. The math seems to reflect this here, from what I see. > On July 26, 2013, 12:41 a.m., Ben Mahler wrote: > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java, lines > > 357-359 > > <https://reviews.apache.org/r/12921/diff/2/?file=327721#file327721line357> > > > > How about: > > mapred.mesos.total.map.slots.minimum > > mapred.mesos.total.reduce.slots.minimum > > > > And for these added variables, can you add the default values in > > mapred-site.xml.patch and add a human friendly comment for others to know > > how to use the knob? I'll update mapred-site.xml in a later commit, if that's okay. - Brenden ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12921/#review23902 ----------------------------------------------------------- On July 30, 2013, 7:24 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12921/ > ----------------------------------------------------------- > > (Updated July 30, 2013, 7:24 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Allowed specification of mininum slot count. > > To ensure Hadoop jobs begin promptly, we can specify a minimum number of > 'hot slots' to be available for use. This addresses the TaskTracker > spin up delay that exists with Hadoop on Mesos. This can be a nuisance > with lower latency applications, such as ad-hoc Hive queries. > > Review: https://reviews.apache.org/r/12921 > > > Diffs > ----- > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java > 0c10874114cbfc0b8cb0dbb6dc83e6ebc09ad926 > > Diff: https://reviews.apache.org/r/12921/diff/ > > > Testing > ------- > > make check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 > > > Thanks, > > Brenden Matthews > >
