----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11161/#review24267 -----------------------------------------------------------
Ship it! hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java <https://reviews.apache.org/r/11161/#comment48091> Range is ordered, so there's no need to do this. Were you concerned about that? If so, how about just adding an assertion or a LOG.fatal, we should better document the Value.Range type in mesos.proto if this part is not clear! hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java <https://reviews.apache.org/r/11161/#comment48093> Can you add a comment indicating why this was added? What did you observe? This is indicative of a bug in mesos if we reported a port available that was in use! s/launched/launched./ - Ben Mahler On July 25, 2013, 1:42 a.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11161/ > ----------------------------------------------------------- > > (Updated July 25, 2013, 1:42 a.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Don't accept offers on the same host/port. > > We'll try to find a port combination that hasn't already been used to > launch a TaskTracker. > > Review: https://reviews.apache.org/r/11161/ > > > Diffs > ----- > > hadoop/mesos/src/java/org/apache/hadoop/mapred/MesosScheduler.java > 279f84e0f0c43ad3cfd9e4442010e706ee3565d9 > > Diff: https://reviews.apache.org/r/11161/diff/ > > > Testing > ------- > > Used in production at airbnb. > > make -j10 check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 && make > hadoop-0.20.205.0 && make hadoop-0.20.2-cdh3u3 > > > Thanks, > > Brenden Matthews > >
