----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13077/#review24270 -----------------------------------------------------------
Ship it! Awesome documentation! hadoop/mapred-site.xml.patch <https://reviews.apache.org/r/13077/#comment48094> s/. /. / on all of these? hadoop/mapred-site.xml.patch <https://reviews.apache.org/r/13077/#comment48095> Can you end with a period? hadoop/mapred-site.xml.patch <https://reviews.apache.org/r/13077/#comment48096> Looks like this one and the ones below are wrapped with newlines, whereas the ones above are not? hadoop/mapred-site.xml.patch <https://reviews.apache.org/r/13077/#comment48097> Close </property> tag on next line. hadoop/mapred-site.xml.patch <https://reviews.apache.org/r/13077/#comment48098> For multi-line tags, perhaps we should format like this: <description> This is my description! </description> - Ben Mahler On July 30, 2013, 7:26 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13077/ > ----------------------------------------------------------- > > (Updated July 30, 2013, 7:26 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Updated Mesos mapred-site.xml for Hadoop. > > > Diffs > ----- > > hadoop/mapred-site.xml.patch 8b3997944f60a9d91c81089a4450e4820526dde3 > > Diff: https://reviews.apache.org/r/13077/diff/ > > > Testing > ------- > > Used in production at Airbnb. > > make check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1 > > > Thanks, > > Brenden Matthews > >
