> On Aug. 1, 2013, 1:17 a.m., Ben Mahler wrote: > > Can you link in MESOS-594 and MESOS-485?
Yes, thanks! > On Aug. 1, 2013, 1:17 a.m., Ben Mahler wrote: > > configure.ac, lines 199-210 > > <https://reviews.apache.org/r/13182/diff/1/?file=332129#file332129line199> > > > > should you split this out into two tests? > > > > GCC_VERSION -> CFLAGS > > > > GXX_VERSION -> CXXFLAGS > > > > A comment as to why we added this flag would be nice for posterity! Added the comment, great idea! Seems a bit overkill to assume that a user might be running a different version of gcc and g++! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13182/#review24401 ----------------------------------------------------------- On Aug. 1, 2013, 9:47 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13182/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2013, 9:47 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-485 and MESOS-594 > https://issues.apache.org/jira/browse/MESOS-485 > https://issues.apache.org/jira/browse/MESOS-594 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > configure.ac 15ada8f84455ed21174f4d831cf3cf1aec3aea73 > > Diff: https://reviews.apache.org/r/13182/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
