----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12432/#review23322 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp <https://reviews.apache.org/r/12432/#comment47204> Why is the function not an Option here, like the rest of the constructors? 3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp <https://reviews.apache.org/r/12432/#comment47205> s/it's/its/ s/descendants/descendants'/ 3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp <https://reviews.apache.org/r/12432/#comment47825> Did you want to hide prepare() and instantiate()? 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp <https://reviews.apache.org/r/12432/#comment47824> Sooooo much nicer! - Ben Mahler On July 10, 2013, 7:36 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12432/ > ----------------------------------------------------------- > > (Updated July 10, 2013, 7:36 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 864b30ea5661cc7f613fdd422fe55f76fdafd1c1 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 429039644832470f7fd2eac19b213905cc81dcd3 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp > 88a936e19342b1891e4b39c42bdaaa45603fda50 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 6a11b018f83651be20026850aeb7cf08d7c85b2f > > Diff: https://reviews.apache.org/r/12432/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
