----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13261/#review24666 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/13261/#comment48774> What does discarded mean in this case? Is it still a failure to recover? Perhaps it needs a separate message that the recovery process was terminated, or? src/slave/slave.cpp <https://reviews.apache.org/r/13261/#comment48775> s/f/rf/? src/slave/slave.cpp <https://reviews.apache.org/r/13261/#comment48776> Even with --strict, they can just rm -rf the latest slave path, so it seems like 'Restart the slave...' is an additional option when --strict is on. s/rm/rm -rf/ ? - Ben Mahler On Aug. 3, 2013, 9:35 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13261/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2013, 9:35 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Brenden Matthews. > > > Bugs: MESOS-613 > https://issues.apache.org/jira/browse/MESOS-613 > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/slave.cpp 7f6e6b456890db438092f19a22e4dd816bb33d04 > > Diff: https://reviews.apache.org/r/13261/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
