> On Aug. 5, 2013, 6:46 p.m., Ben Mahler wrote: > > How about keeping disconnected slaves in a separate map instead of adding > > the bool?
after offline discussion, decided to stick with a boolean flag for simplicity. > On Aug. 5, 2013, 6:46 p.m., Ben Mahler wrote: > > src/tests/slave_recovery_tests.cpp, line 1400 > > <https://reviews.apache.org/r/13259/diff/2/?file=336046#file336046line1400> > > > > s/DisconnectedSlave/DisconnectedSlaveRegisters/ ? called it RegisterDisconnectedSlave - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13259/#review24661 ----------------------------------------------------------- On Aug. 3, 2013, 8:34 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13259/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2013, 8:34 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Brenden Matthews. > > > Bugs: MESOS-614 > https://issues.apache.org/jira/browse/MESOS-614 > > > Repository: mesos-git > > > Description > ------- > > When the master is waiting for a disconected checkpointed slave to > "reregister", but the restarted slave tries to "register" (because it failed > recovery) the master should remove the old slave. > > > Diffs > ----- > > src/master/master.hpp 8ec0c17c71b7b4679d4f712d0fb742d420c9152d > src/master/master.cpp b0a2757af3ec83ead53374504fe24d3a8f7673ad > src/tests/slave_recovery_tests.cpp 1871e3ba41e65dcbd4b95779dda068f6a1a2ecb3 > > Diff: https://reviews.apache.org/r/13259/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
