----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13339/#review24751 -----------------------------------------------------------
Ship it! src/master/master.cpp <https://reviews.apache.org/r/13339/#comment48864> Why do you need to do this all the time. You probably need a comment. src/master/master.cpp <https://reviews.apache.org/r/13339/#comment48865> Please identify the dependency with needing the pid above! src/tests/slave_recovery_tests.cpp <https://reviews.apache.org/r/13339/#comment48867> - Benjamin Hindman On Aug. 6, 2013, 8:47 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13339/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2013, 8:47 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-619 > https://issues.apache.org/jira/browse/MESOS-619 > > > Repository: mesos-git > > > Description > ------- > > KillTask information is now cached at the master, so that it can properly > reconcile killed tasks when a slave re-registers. > > > Diffs > ----- > > src/master/master.hpp 8ec0c17c71b7b4679d4f712d0fb742d420c9152d > src/master/master.cpp b0a2757af3ec83ead53374504fe24d3a8f7673ad > src/tests/slave_recovery_tests.cpp c451e0f4c571a646d375aa89e806e1a4058d39e7 > > Diff: https://reviews.apache.org/r/13339/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
