----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13396/#review24852 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp <https://reviews.apache.org/r/13396/#comment49030> I think it would be clearer if we just kept the 'group && session', just 'group', just 'session'. - Benjamin Hindman On Aug. 8, 2013, 12:28 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13396/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2013, 12:28 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > This change makes Process::session an option in order to compensate for the > fact that on OS X, getsid() does not work for zombie processes. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 448739e313bf5127e7e5469dd4090445dc5c5405 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp > 9dc314c17c5ca3abc453fa4234d971f53acd60d6 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp > 4161e77ae9315029046634bd2233a258aa84e1f7 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp > 9dbb89fff16cf688e7f9acd12c70021f6c8ca3a0 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > f926056239b9cd86041e497c7c3b8eadc45f44c0 > > Diff: https://reviews.apache.org/r/13396/diff/ > > > Testing > ------- > > make check on OS X (was broken and this fixed the issues) > > > Thanks, > > Ben Mahler > >
