----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13442/#review24938 -----------------------------------------------------------
Ship it! Can you document what this means for posterity? As in, if a master fails over while the slave is disconnected in cleanup mode, the new master will not forward the updates and the slave will retry forever (can be fixed with registrar)? - Ben Mahler On Aug. 9, 2013, 5:09 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13442/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2013, 5:09 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-631 > https://issues.apache.org/jira/browse/MESOS-631 > > > Repository: mesos-git > > > Description > ------- > > I might kill/disable 'cleanup' soon. In the meanwhile, this is the right > thing for "cleanup" to do. > > > Diffs > ----- > > src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac > src/tests/slave_recovery_tests.cpp bd755f6879bd84f1b95d9550b7a524a3771cedf8 > > Diff: https://reviews.apache.org/r/13442/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
