----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13454/#review25020 -----------------------------------------------------------
Ship it! src/master/master.cpp <https://reviews.apache.org/r/13454/#comment49183> Why 56 dashes? How about 50? Can you add a newline where there are newlines in the string? So: ... "Existing ExecutorInfo:\n" + stringify(executorInfo) + ... src/slave/slave.cpp <https://reviews.apache.org/r/13454/#comment49184> Instead of 49 dashes can you use 50? - Ben Mahler On Aug. 12, 2013, 1:11 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13454/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2013, 1:11 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/common/type_utils.hpp 9320ced40d63a7883aced712113b67eaf3ca8925 > src/master/master.cpp a2f8929987f95e796aba71063223aea7003bf3df > src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac > src/tests/resource_offers_tests.cpp > a96e7757455ef9da21cf62e810f489415d3d2134 > > Diff: https://reviews.apache.org/r/13454/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
