> On Aug. 9, 2013, 11:18 p.m., Jiang Yan Xu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/time.hpp, line 119 > > <https://reviews.apache.org/r/13451/diff/1/?file=339442#file339442line119> > > > > I am not sure what is the best way to handle the error here. Maybe this > > is alright. Just wanted someone else to offer an opinion. > > Ben Mahler wrote: > Do you know when EOVERFLOW is returned? Do we guard sufficiently in > Time::create / Duration::create to prevent it? > > Ben Mahler wrote: > I think it's fine as is, additionally we could append strerror(errno) to > the stream. > > Jie Yu wrote: > I looked at the manual, seems that errno won't be set if an error occurs.
Does Linux not conform to POSIX here? From: http://pubs.opengroup.org/onlinepubs/009696699/functions/gmtime.html Upon successful completion, gmtime_r() shall return the address of the structure pointed to by the argument result. If an error is detected, gmtime_r() shall return a null pointer and set errno to indicate the error. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13451/#review24951 ----------------------------------------------------------- On Aug. 9, 2013, 10:43 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13451/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2013, 10:43 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Vinod Kone, and Jiang > Yan Xu. > > > Repository: mesos-git > > > Description > ------- > > Moved time.hpp from libprocess to stout. > > Also, fixed a race condition in Time output function by using an reentrant > version of gmtime (gmtime_r). > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am 0cd407c > 3rdparty/libprocess/3rdparty/stout/Makefile.am 770378d > 3rdparty/libprocess/3rdparty/stout/include/stout/time.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/time_tests.cpp PRE-CREATION > 3rdparty/libprocess/Makefile.am 130d40c > 3rdparty/libprocess/include/process/clock.hpp 82ae3c6 > 3rdparty/libprocess/include/process/statistics.hpp fbae641 > 3rdparty/libprocess/include/process/time.hpp 307fd2c > 3rdparty/libprocess/include/process/timeout.hpp 4634b9f > 3rdparty/libprocess/src/process.cpp 7cade9a > 3rdparty/libprocess/src/statistics.cpp d4ba9f1 > 3rdparty/libprocess/src/tests/process_tests.cpp 5009610 > 3rdparty/libprocess/src/tests/statistics_tests.cpp 8695f45 > 3rdparty/libprocess/src/tests/time_tests.cpp a25827e > > Diff: https://reviews.apache.org/r/13451/diff/ > > > Testing > ------- > > make -j4 check > > > Thanks, > > Jie Yu > >
