----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13485/#review25103 -----------------------------------------------------------
Ship it! Can you add TODOs on each of the .values() calls to use foreachvalue when LinkeHashMap supports it? I want to make sure we keep track of these unnecessary copies and revert them once we can. src/slave/http.cpp <https://reviews.apache.org/r/13485/#comment49321> Do end users need to know the semantic difference between terminated tasks and completed tasks? 1. If so, please update the webui to show them (probably as completed_tasks rather than a separate table for terminated_tasks). 2. If not, please combine them into completed_tasks. IMO #2 is simpler. Ship it for #2 :) - Ben Mahler On Aug. 12, 2013, 5:49 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13485/ > ----------------------------------------------------------- > > (Updated Aug. 12, 2013, 5:49 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-497 > https://issues.apache.org/jira/browse/MESOS-497 > > > Repository: mesos-git > > > Description > ------- > > This will ensure that queued tasks are launched in the same order as they are > received! > > > Diffs > ----- > > src/slave/http.cpp c45dfb457971626565185f103538f1ec893abc40 > src/slave/slave.hpp 8ba605bafae36e0418969ba9cea51dd0cd7e91db > src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac > > Diff: https://reviews.apache.org/r/13485/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
