-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13609/#review25224
-----------------------------------------------------------

Ship it!



src/slave/slave.cpp
<https://reviews.apache.org/r/13609/#comment49522>

    s/that//?



src/slave/slave.cpp
<https://reviews.apache.org/r/13609/#comment49523>

    I don't have a great suggestion for a more descriptive message, but how 
about:
    
    "Task lost during slave recovery (due to the slave restarting prior to the 
task reaching the executor)."
    
    Thoughts?


- Ben Mahler


On Aug. 15, 2013, 10:55 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13609/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2013, 10:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Bugs: MESOS-646
>     https://issues.apache.org/jira/browse/MESOS-646
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> Fixed 2 things:
> 
> --> Properly handling queued tasks that were not launched.
> --> Properly killing executor when it hasn't registered yet.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp ef8b64f952b7335b7f20f6c69e49450eecf563ce 
>   src/slave/slave.cpp b41f2bd6ec0cdf00b0ff166d5089a984b2707ac2 
> 
> Diff: https://reviews.apache.org/r/13609/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Reply via email to