----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13623/#review25240 -----------------------------------------------------------
Ship it! But please no stderr logging inside stout. :) 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp <https://reviews.apache.org/r/13623/#comment49538> Maybe ignoreEOF isn't the write name, since we do two reads: Read the size (this always treats EOF as None()). Read the proto (this optionally treats EOF as None()). Maybe we should call this "ignorePartial"? 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp <https://reviews.apache.org/r/13623/#comment49535> Stout shouldn't be writing to stderr, can you remove this? - Ben Mahler On Aug. 16, 2013, 6:13 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13623/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2013, 6:13 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > Added the ability so that slave recovery can use it when handling partial > protobuf writes. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > 035541656f6577d758f40fb81f3d05a4042d461c > > Diff: https://reviews.apache.org/r/13623/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
