----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13624/#review25242 -----------------------------------------------------------
Ship it! src/slave/state.cpp <https://reviews.apache.org/r/13624/#comment49539> If you want to log the partials, you could check to see if fd is at SEEK_END and if not, log the fact that a partial was ignored, or you could just ignore the partials completely ;) - Ben Mahler On Aug. 16, 2013, 6:16 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13624/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2013, 6:16 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-648 > https://issues.apache.org/jira/browse/MESOS-648 > > > Repository: mesos-git > > > Description > ------- > > While testing we have observed partial status update writes when the slave > dies in the midst of writing an update. This is an attempt to handle that. > > > Diffs > ----- > > src/slave/state.cpp cd74e41c5919950e6528f071951e31df5bb93c18 > > Diff: https://reviews.apache.org/r/13624/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
