----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13564/#review25261 -----------------------------------------------------------
Not your problem and these might be general concepts and data structures but I wish there was more documentation or links to public web pages in these files which would go a long way toward helping people like me reviewing these :) - Jiang Yan Xu On Aug. 14, 2013, 6:35 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13564/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2013, 6:35 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Vinod > Kone, and Jiang Yan Xu. > > > Repository: mesos-git > > > Description > ------- > > The current implementation of Gate does not support timeout. We need this so > that we can rewrite Latch to use Gate. The newly added timeout support is > Clock aware (i.e. you can advance the clock using Clock::advance()). > > This patch also kills some of the unused functions in Gate, and refactors the > Gate cleanup logic (use shared_ptr instead of depending on Gate::empty() > function). > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 130d40c > 3rdparty/libprocess/include/process/gate.hpp PRE-CREATION > 3rdparty/libprocess/src/gate.hpp 954f620 > 3rdparty/libprocess/src/gate.cpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp 7cade9a > > Diff: https://reviews.apache.org/r/13564/diff/ > > > Testing > ------- > > make -j8 check > > > Thanks, > > Jie Yu > >
