-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13620/
-----------------------------------------------------------
(Updated Aug. 19, 2013, 8:39 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Ben's review - added helpers to the Framework and Slave structs for allocating
and deallocating.
Bugs: MESOS-621
https://issues.apache.org/jira/browse/MESOS-621
Repository: mesos-git
Description
-------
Previously, when a slave or framework was removed the allocator didn't recover
the associated resources, instead relying on the master calling
Allocator::resourcesRecovered for all resources allocated. This was difficult
to reason about and meant that the allocator's state was sometimes inconsistent
with the reality of the cluster (for example, a framework could have resources
allocated to it on a slave that had been removed), so this patch fixes this.
This also solves a problem with the upcoming implementation of revocation where
resources were recovered from a removed framework and the allocator didn't know
what that framework's role is because it had been removed.
Diffs (updated)
-----
src/master/hierarchical_allocator_process.hpp 183b205
src/master/master.cpp d53b8bb
Diff: https://reviews.apache.org/r/13620/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
