----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13699/#review25359 -----------------------------------------------------------
src/master/master.hpp <https://reviews.apache.org/r/13699/#comment49749> These semantics are a little different from how we handle registration/re-registration times for the framework. For framework we set both when a framework registers and then keep updating reregistration time whenever a framework failovers. Do we want to do something similar with slaves? I'm ok with not showing anything in re-registered column if slave never re-registered. But in that case we should fix framework's times semantics too. Thoughts? src/master/master.cpp <https://reviews.apache.org/r/13699/#comment49746> why inside the if loop? I think we need to set this even when it re-registers with a failed over master. - Vinod Kone On Aug. 21, 2013, 3:28 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13699/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2013, 3:28 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-651 > https://issues.apache.org/jira/browse/MESOS-651 > > > Repository: mesos-git > > > Description > ------- > > With slave recovery, this proves useful for seeing when slaves have > re-registered with the master. > > > Diffs > ----- > > src/master/http.cpp 1ac84a9f75df43632ddbd1fec50333c159651f15 > src/master/master.hpp 30752d2698931624fdf4aa6e40ef9fc4ec58dc6d > src/master/master.cpp d53b8bb97da45834790cca6e04b70b969a8d3453 > src/webui/master/static/slaves.html > 15877b7069a11b9feda58be313620f94624a62ea > > Diff: https://reviews.apache.org/r/13699/diff/ > > > Testing > ------- > > make check > > manual runs with a master (local + zk) and rolling slaves / master. > > > Thanks, > > Ben Mahler > >
