----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13729/#review25405 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Aug. 22, 2013, 6:20 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13729/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2013, 6:20 a.m.) > > > Review request for mesos, Ben Mahler and Jie Yu. > > > Bugs: MESOS-656 > https://issues.apache.org/jira/browse/MESOS-656 > > > Repository: mesos-git > > > Description > ------- > > The test was broken because it did not wait for executor to terminate (and > cgroups to be cleaned up) before restarting the slave. So both the recovered > slave's isolator and IsolatorTest's teardown were simultaneously attempting > to cleanup the cgroup causing errors. > > > Diffs > ----- > > src/tests/slave_recovery_tests.cpp 314786060cbf16144feb7ea8057e24c3d2595f31 > > Diff: https://reviews.apache.org/r/13729/diff/ > > > Testing > ------- > > make check (15 times) > > > Thanks, > > Vinod Kone > >
