[
https://issues.apache.org/jira/browse/MESOS-488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Mahler reassigned MESOS-488:
-------------------------------------
Assignee: Benjamin Mahler (was: Benjamin Hindman)
> Master should not send FrameworkError messages if the same scheduler tries to
> re-register
> ------------------------------------------------------------------------------------------
>
> Key: MESOS-488
> URL: https://issues.apache.org/jira/browse/MESOS-488
> Project: Mesos
> Issue Type: Bug
> Affects Versions: 0.9.0, 0.10.0, 0.11.0, 0.12.0, 0.13.0
> Reporter: Vinod Kone
> Assignee: Benjamin Mahler
> Fix For: 0.15.0
>
>
> We have seen this in production at Twitter.
> Scheduler driver's re-register messages were backed up on the master (it was
> busy). When the master acted on the 2nd re-register message, it incorrectly
> sent a FrameworkError message to the scheduler that just re-registered.
> This bug can cause unnecessary additional failovers, if say, the master is
> delayed processing a re-registration attempt from a scheduler.
> // Replace the scheduler for a framework with a new process ID, in the
> // event of a scheduler failover.
> void Master::failoverFramework(Framework* framework, const UPID& newPid)
> {
> const UPID& oldPid = framework->pid;
> /** NEED TO GUARD AGAINST newPid == oldPid FOR RETRIES! */
> {
> FrameworkErrorMessage message;
> message.set_message("Framework failed over");
> send(oldPid, message);
> }
> ...
> }
> Sending the FrameworkErrorMessage here always is incorrect, we should not be
> sending it when the scheduler driver is simply re-trying the initial failover
> re-registration.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
