-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13764/#review25488
-----------------------------------------------------------


Did you run this repeatedly in a loop on both osx and linux?


src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49932>

    Now that you have a expectation on offers after the slave restarts below, 
you shouldn't be receiving any more offers. So kill WillRepeatedly().



src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49934>

    move this to before the slave is restarted, because theoretically offers 
could be offered by the time you are here!



src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49930>

    s/Scheduler/Master/



src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49933>

    ditto..kill this.



src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49935>

    ditto..move



src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49936>

    s/Scheduler/Master/



src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49937>

    ditto..kill



src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49938>

    ditto..move up



src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49939>

    ditto..kill



src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49940>

    ditto..move



src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49941>

    ditto..kill



src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/13764/#comment49942>

    ditto..move


- Vinod Kone


On Aug. 23, 2013, 3:56 a.m., Ian Downes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13764/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2013, 3:56 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_recovery_tests.cpp 548e8c0 
> 
> Diff: https://reviews.apache.org/r/13764/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ian Downes
> 
>

Reply via email to