----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13598/#review25697 -----------------------------------------------------------
Hi Vinson, this has been reverted as it broke the ZK tests (it appears a make clean was required to re-compile and catch this), please see: https://issues.apache.org/jira/browse/MESOS-670 - Ben Mahler On Aug. 23, 2013, 5:49 p.m., Vinson Lee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13598/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2013, 5:49 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Eric > Biederman, Ian Downes, David Mackey, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Author: Vinson Lee <[email protected]> > > Update zookeeper to 3.3.6. > > Fix clang build errors. > > src/hashtable/hashtable_itr.c:42:1: error: redefinition of a 'extern inline' > function 'hashtable_iterator_key' is not supported in C99 mode > hashtable_iterator_key(struct hashtable_itr *i) > ^ > src/hashtable/hashtable_itr.h:36:1: note: previous definition is here > hashtable_iterator_key(struct hashtable_itr *i) > ^ > src/hashtable/hashtable_itr.c:46:1: error: redefinition of a 'extern inline' > function 'hashtable_iterator_value' is not supported in C99 mode > hashtable_iterator_value(struct hashtable_itr *i) > ^ > src/hashtable/hashtable_itr.h:45:1: note: previous definition is here > hashtable_iterator_value(struct hashtable_itr *i) > ^ > > Signed-off-by: Vinson Lee <[email protected]> > > > The complete patch which includes the tarball update can be found at > http://people.freedesktop.org/~vlee/patches/0001-Update-zookeeper-to-3.3.6.patch. > > > Diffs > ----- > > 3rdparty/versions.am 5932e1f > src/python/setup.py.in 77fa880 > > Diff: https://reviews.apache.org/r/13598/diff/ > > > Testing > ------- > > make > > > Thanks, > > Vinson Lee > >
