Hi Ben, A revert is a pretty strict/harsh thing to do. In the future, why not simply fix your local copy of the code, submit JIRA tickets, attach Review Board patches, etc., but please, reverts should not be used in practice -- especially without discussion.
Cheers, Chris -----Original Message----- From: Benjamin Mahler <[email protected]> Reply-To: "[email protected]" <[email protected]> Date: Wednesday, August 28, 2013 4:12 PM To: dev <[email protected]> Subject: Reverts >Hi all, > >I've just reverted two commits that were causing issues on master: > >commit 5e8e4da4e8276a022fef3667f3dc1415e7236149 >Author: Benjamin Mahler <[email protected]> >Date: Wed Aug 28 15:46:20 2013 -0700 > > Reverted "Upgraded ZooKeeper from 3.3.4 to 3.3.6.". > > This reverts commit eb1cd4a7c0ad4310f090d4f0643cf4059ac5246b. > >commit 400a88f9817bb102522b08b83dca400380ad8a9b >Author: Vinod Kone <[email protected]> >Date: Tue Aug 27 13:36:42 2013 -0400 > > Added resource checks to slave recovery tests to ensure resources > are re-offered after restarts. > > From: Ian Downes <[email protected]> > Review: https://reviews.apache.org/r/13764 > >I will follow up with the contributors to let them know. > >Thanks! >Ben
