----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13880/#review25773 -----------------------------------------------------------
Ship it! Ship It! - Ben Mahler On Aug. 28, 2013, 4:24 a.m., Vinson Lee wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13880/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2013, 4:24 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Chi Zhang, Eric > Biederman, David Mackey, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > Author: Vinson Lee <[email protected]> > > launcher: Fix os::chdir return value checking. > > os::chdir returns a boolean value and not an integer value. > > Fixes "Operands don't affect result" defects reported by Coverity. > > Signed-off-by: Vinson Lee <[email protected]> > > > Diffs > ----- > > src/launcher/launcher.cpp 7bf127a > > Diff: https://reviews.apache.org/r/13880/diff/ > > > Testing > ------- > > make > > > Thanks, > > Vinson Lee > >
