----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13921/#review25814 -----------------------------------------------------------
Ship it! Thanks for fixing this. Too bad we don't have a test for this. The reason we didn't catch this earlier even though we added resource accounting checks in all our slave recovery tests is because we use command executors :( Command executors neither use resources nor are known to the master. I think its time we implemented a test executor that could be actually launched. I'm going to create a ticket for it. src/master/master.hpp <https://reviews.apache.org/r/13921/#comment50352> s/reconcileTasks/reconcile/ now that we are doing both tasks and executors. src/master/master.cpp <https://reviews.apache.org/r/13921/#comment50353> s/must// ? - Vinod Kone On Aug. 30, 2013, 11:16 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13921/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2013, 11:16 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Bugs: MESOS-673 > https://issues.apache.org/jira/browse/MESOS-673 > > > Repository: mesos-git > > > Description > ------- > > See MESOS-673. > > > Diffs > ----- > > src/master/master.hpp 6bd899894e7b0cd5178d52f930a60be11f836976 > src/master/master.cpp 874d7fac42d3e948cd0f90d735873120bc75cb54 > > Diff: https://reviews.apache.org/r/13921/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
