----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13946/#review25856 -----------------------------------------------------------
Ship it! Looks good, does this have a visual change? - Ben Mahler On Sept. 3, 2013, 5:33 p.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13946/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2013, 5:33 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-661 > https://issues.apache.org/jira/browse/MESOS-661 > > > Repository: mesos-git > > > Description > ------- > > Preserved newlines for copy/paste in Firefox > > Due to a difference in implementation, Firefox does not preserve > newlines on copy when output is styled with "white-space: pre-wrap;"[1]. > Firefox does preserve newlines if the output is wrapped in <pre><code>. > Switching to the semantic markup fixes Firefox and functions the same > as before in Chrome and in Safari. > > This change addresses MESOS-661. > > [1] https://bugzilla.mozilla.org/show_bug.cgi?id=116083 > > > Diffs > ----- > > src/webui/master/static/pailer.html > 96784dc48a5e72926d674893e33f1fae3f9a6d3e > > Diff: https://reviews.apache.org/r/13946/diff/ > > > Testing > ------- > > > Thanks, > > Ross Allen > >
