----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13954/#review25876 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/13954/#comment50446> +10 on having UUIDs on messages to track the runs. That said this comment is more generic and applies to every message received by the slave. So, maybe this is not the right place to put it? How about putting this comment in initialize() where we install the handlers for messages? Also for reregistered() (and registered() too?) I propose we ignore the message when in RECOVERING unless info.id() != slaveId, in which case we crash. Basically the same as we do in DISCONNECTED and RUNNING states. - Vinod Kone On Sept. 4, 2013, 12:31 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13954/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2013, 12:31 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > These were missing declarations in the header file and since they are defined > at the bottom of slave.cpp they will not be used by all of the slave.cpp code. > > > Diffs > ----- > > src/slave/slave.hpp ce2b0dad1228363496875f233c14a602d9fb9dbe > src/slave/slave.cpp 7f23b56c4db8b1828b3e0d02b7a4e7375cb76211 > > Diff: https://reviews.apache.org/r/13954/diff/ > > > Testing > ------- > > manual > > > Thanks, > > Ben Mahler > >
