----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13602/#review25915 -----------------------------------------------------------
Ship it! This is a great cleanup, please ping benh for a review on this! 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/13602/#comment50583> Why are these pointers? Seems non-obvious so maybe a comment? 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/13602/#comment50580> new Data() 3rdparty/libprocess/include/process/future.hpp <https://reviews.apache.org/r/13602/#comment50581> new Data() - Ben Mahler On Aug. 15, 2013, 7:17 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13602/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2013, 7:17 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Vinod > Kone, and Jiang Yan Xu. > > > Repository: mesos-git > > > Description > ------- > > Replaced manual reference counting with shared_ptr in Future. This allows us > to kill some nasty copy and deallocation functions in Future (e.g. cleanup, > copy). > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp daf4b92 > > Diff: https://reviews.apache.org/r/13602/diff/ > > > Testing > ------- > > make check -j8 > > > Thanks, > > Jie Yu > >
