----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13949/#review25949 -----------------------------------------------------------
Looks like this test and the previous ones can leave files/dirs around if the tests fail. You should probably use a fixture (perhaps a subclass of TemporaryDirectoryTest) to ensure these are properly cleaned. - Vinod Kone On Sept. 3, 2013, 6:23 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13949/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2013, 6:23 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Vinod > Kone, and Jiang Yan Xu. > > > Repository: mesos-git > > > Description > ------- > > Verify whether our replicated log implementation can survive a single disk > failure. Currently, the test fails. > > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from LogTest > [ RUN ] LogTest.DiskFailure > ../../../mesos/src/tests/log_tests.cpp:1197: Failure > Value of: result.isNone() > Actual: false > Expected: true > [ FAILED ] LogTest.DiskFailure (1930 ms) > [----------] 1 test from LogTest (1930 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (1930 ms total) > [ PASSED ] 0 tests. > [ FAILED ] 1 test, listed below: > [ FAILED ] LogTest.DiskFailure > > 1 FAILED TEST > > > Diffs > ----- > > src/tests/log_tests.cpp fbfbf33 > > Diff: https://reviews.apache.org/r/13949/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
