> On Sept. 9, 2013, 7:15 p.m., Brenden Matthews wrote: > > Looks like this patch got messed up (perhaps a bad merge/rebase?). Can you > > double check?
Whoops, let me fix that now... - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14039/#review25998 ----------------------------------------------------------- On Sept. 9, 2013, 7:04 p.m., Jason Dusek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14039/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2013, 7:04 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > List modules instead of using package=['.'] > > Using packages= without an __init__.py is recommended against in the docs and > happens to break FPM. From the python.org documentation: > > The packages option tells the Distutils to process (build, distribute, > install, etc.) all pure Python modules found in each package mentioned in > the packages list. In order to do this, of course, there has to be a > correspondence between package names and directories in the filesystem. The > default correspondence is the most obvious one, i.e. package distutils is > found in the directory distutils relative to the distribution root. Thus, > when you say packages = ['foo'] in your setup script, you are promising that > the Distutils will find a file foo/__init__.py (which might be spelled > differently on your system, but you get the idea) relative to the directory > where your setup script lives. If you break this promise, the Distutils will > issue a warning but still process the broken package anyway. > > http://docs.python.org/2/distutils/setupscript.html#listing-whole-packages > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > e8561dff4e85df88ef5e2362ad054d1cc209d546 > 3rdparty/libprocess/3rdparty/glog-0.3.1.tar.gz PRE-CREATION > 3rdparty/libprocess/3rdparty/glog-0.3.3.tar.gz > 92fa52d296fea2884bd58d6010b0f869611999f7 > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 0428aa88bd9049212628dc65f7585b86aa35933e > 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp > 3a20e86b1ab44cbee4d5d23010c35a304461875f > 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp > cea69889784caa6c527a857c37620da035220beb > 3rdparty/libprocess/3rdparty/stout/include/stout/json.hpp > 4406d070be984803b39c6fe3197b9a0c4c3d4bf8 > 3rdparty/libprocess/3rdparty/stout/include/stout/linkedhashmap.hpp > a27ec26260bee968c76f00f3ab21d5f5a892daee > 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp > 42b75a56966e735b4ec8f9ce55800262dbb25428 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 728122ec9eeb903723daa9294e258fed2141bea6 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp > 64e3b5d211aae9120f8854397b07266e6cfe08ea > 3rdparty/libprocess/3rdparty/stout/include/stout/os/killtree.hpp > 25e99371b15e72b6d39dd476a6aefb12b5362dfc > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp > 25d5903f7c9c9782b46295088fc7b737e17af1d3 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp > 7d0256686f917251230eae372e058250a6d40591 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/process.hpp > d754601d6dbc12f2db124a42eae13d4b5c68803c > 3rdparty/libprocess/3rdparty/stout/include/stout/os/pstree.hpp > 4637e68d3d641cb65136c418c73023b2e9c8f7a5 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp > 0c5b2eff884f2b5a17495a1321dc5e48a8b664b5 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sendfile.hpp > 668e4da463fedbd5866d66f2056d7d985f0dc201 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/signals.hpp > 215ee55d7c9d8a5f9689d056cae534d9693e7642 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/sysctl.hpp > 065aadad66a5bc5a6cfae93b5aa31820229bd6eb > 3rdparty/libprocess/3rdparty/stout/include/stout/proc.hpp > c3eac302b0e6ba7bc5d208fa486ad25876309d0d > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp > 3fa7fe6261bb83b1fc321e410b3bb907ceb71a7e > 3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp > 29ada8a4a0396f889eb2583c3b3ff622050125af > 3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp > aca97ca4ec13d7cc4875ec316efba672c782e5dc > 3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp > 194906edf42ed77d8e9643fa0a277d72f36c886d > 3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp > 66caa0490189cb1aff3af1631fbcf7150658b6cc > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 0ef2eb5b95b76a5837b98854b09bedfb43f0e5eb > 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp > bb174ba6e6383c9ce7aeb2ae964c5b87a38b50df > 3rdparty/libprocess/3rdparty/versions.am > 7cb4f2fefe27ecd80019337c205adf5f3312a709 > 3rdparty/libprocess/Makefile.am 130d40c3301bc6ffa6d8e531e48d8d9406a61cf7 > 3rdparty/libprocess/include/process/collect.hpp > 27e27299bf54c9be55240bee01476d06c530631d > 3rdparty/libprocess/include/process/event.hpp > cf728dafc7a5ec7bd3c7ab6fe46f54b41777aa81 > 3rdparty/libprocess/include/process/limiter.hpp > bbe82266b82bf226f4a9048640a41c424f8d13b0 > 3rdparty/libprocess/include/process/process.hpp > b502324361c38ba6280c937d53cb2fe125193126 > 3rdparty/libprocess/include/process/protobuf.hpp > e0338d979d2d58eb757662e4ff1d97587a93a2ee > 3rdparty/libprocess/src/config.hpp cbaf41d81846c061107e06a8bde197d30f2e469c > 3rdparty/libprocess/src/process.cpp > 8c427a064c2215a9b4b1c4c00cb8540fcc8e89df > 3rdparty/libprocess/src/tests/process_tests.cpp > 5009610173b8774c928c4f55aa025c48807839de > CHANGELOG d8e9c10f25c1a3d55545e132ccb28dd6dee7c8b4 > configure.ac dec18971ab1be34c0c25f5213e3bc318d2d90214 > docs/Upgrades.md 4c4b169c8f2748e47cfcdf916e2c12bd5c5ce7a6 > include/mesos/scheduler.hpp cf3ecdaaf40fd878a80fe0b6f7e61a0997329cbd > src/Makefile.am 3eae9642b639e78f101e7fe580aa803beadbebda > src/common/type_utils.hpp 674a8820c339c6446dfa7d444457477ab4512e79 > src/common/values.cpp ce26119f7707749ee9b6fbad74d486407619ee45 > src/examples/java/TestFramework.java > 687ed0d012ccbb20ecb6830e9e86527273361298 > src/examples/long_lived_framework.cpp > 08ccc75df13467a1e823d35afe69cd0dc521fcf3 > src/examples/python/test_framework.py > eb2012735a075233850788b7e9d138a78447bae6 > src/examples/test_framework.cpp 0065de16c00a964959d1fceb824c436c20e992ee > src/exec/exec.cpp d370560653ce8d30f490b31ccd546e67e57e3b07 > src/files/files.cpp 69d68523b0e2a8578ff3ec1c633c61a7d29dd007 > src/java/jni/org_apache_mesos_state_AbstractState.cpp > 2ee0b1b631b80ec783e6bce683cdeaa77e56b2aa > src/java/jni/org_apache_mesos_state_LevelDBState.cpp > 30f63092d3839485da2a8d818febfa85c81df49f > src/java/jni/org_apache_mesos_state_ZooKeeperState.cpp > c40e6858bc7534443e01ad189173e8cdb56b0fba > src/java/src/org/apache/mesos/state/AbstractState.java > 774b2176f9ec92c2e9c64470e3415d9e03a97c59 > src/java/src/org/apache/mesos/state/LevelDBState.java > d4e7aa9adbaac093065126a6337c6117317b9514 > src/java/src/org/apache/mesos/state/ZooKeeperState.java > f3d939f73192d2cec470ca1a7ff35e7b0a9b93a6 > src/launcher/executor.cpp b73ab479500a7347a38ba53acecfab9229f1080d > src/launcher/launcher.hpp 104fe812ddd2b75b14ec0b40d192f58cdba3603a > src/launcher/launcher.cpp 6f2677a5e04871fa09ca3d0a926e1474eff609c7 > src/launcher/main.cpp de64609905ee63096c0173fe7e64a1eafea5d6bf > src/master/hierarchical_allocator_process.hpp > 183b205663e82aa53bb3898cac0b1be10b9a4f3f > src/master/http.cpp f2a535a002f07784db724f6fdedfb26b271d6327 > src/master/master.hpp 6bd899894e7b0cd5178d52f930a60be11f836976 > src/master/master.cpp 874d7fac42d3e948cd0f90d735873120bc75cb54 > src/messages/messages.proto 4d400c2d8f6ecb9f7cf8635b2a98341206bbb6c5 > src/python/setup.py.in 77fa880a16f1c8ccecb7bb0db3cfea75413b104a > src/sched/sched.cpp c399f2481259683a8e178abb3478307042292f23 > src/slave/cgroups_isolator.cpp 676768e6b8bd13820467309814845257a9c47e02 > src/slave/constants.hpp bbbbfd328773692f05eb29c2989f0097a45cede0 > src/slave/constants.cpp 8c74c004979e33b4179491abaffebd207fc4533a > src/slave/flags.hpp ea1e4f7b7c6a5923ca94921299197a0037a40b4f > src/slave/http.cpp 62fbb37a1924062543bf9db4229704bdef91601d > src/slave/monitor.cpp 8e1eb353c55f9a04b07c382c10c669715a2d7ac2 > src/slave/paths.hpp 3a02a0d6a977b1af7c7f7b9d75bd4a44b0c53c2b > src/slave/process_isolator.cpp fa8029325122f6b1f4ce2ea8492e7a33a7a982f3 > src/slave/slave.hpp ce2b0dad1228363496875f233c14a602d9fb9dbe > src/slave/slave.cpp 7f23b56c4db8b1828b3e0d02b7a4e7375cb76211 > src/slave/state.hpp f06cba8b9b197ea40e6c255e158d920b4ba602ff > src/slave/state.cpp 51bc8f4522c3c584d54dbea4e6c4d5eae6d30dbe > src/slave/status_update_manager.hpp > 1f55f868548ae79052856e0255097b447ffe7573 > src/slave/status_update_manager.cpp > b6afeb18d3bd97ca4f4238b2ffbf6bd7de8e6888 > src/tests/allocator_zookeeper_tests.cpp > 6e3214c15c14dc8ba82082738c172c8833cd0887 > src/tests/balloon_framework_test.sh > 8e99456548015ee92904b228b6c09355ed3388e4 > src/tests/fault_tolerance_tests.cpp > 10e52c401476eb8416361de49b8e4061bb7ac4f3 > src/tests/reaper_tests.cpp 608ec0eff4eaae115d75621937a39b22e3bdb068 > src/tests/resource_offers_tests.cpp > 3888e461de5c8fa807cff2fd2bd7ca12c704823a > src/tests/resources_tests.cpp 964a1b65e112fc1f8573647dd87fc9d302798e10 > src/tests/slave_recovery_tests.cpp 57636c101436db6946388d5602c4e880be9118ac > src/tests/status_update_manager_tests.cpp > cf420e4764356402f05b27c3b8e8802c21a58f8e > src/webui/master/static/slaves.html > 99b1c355be1afc0dfa917960ec9d2e699bd3ad1f > > Diff: https://reviews.apache.org/r/14039/diff/ > > > Testing > ------- > > > Thanks, > > Jason Dusek > >
