----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14043/#review26009 -----------------------------------------------------------
Ship it! src/slave/cgroups_isolator.hpp <https://reviews.apache.org/r/14043/#comment50760> How about adding @params for consistency with other functions in this file? src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/14043/#comment50775> It is too bad that, with this logic, when the system is under oom, a container that is within its memory limits could be arbitrarily killed by the kernel. But I don't know whats the good way to solve this yet. src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/14043/#comment50761> Not yours but can you s/Listening on OOM events failed/Failed to listen to OOM events/ src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/14043/#comment50762> also log the executorId, frameworkIds and uuids here. src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/14043/#comment50772> uuid? src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/14043/#comment50773> uuid? src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/14043/#comment50763> Not yours, but can you also log the executorId, frameworkID and uuids? src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/14043/#comment50764> ditto src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/14043/#comment50765> ditto src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/14043/#comment50767> s/reached/ reached/ src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/14043/#comment50768> s/executor/ executor/ src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/14043/#comment50769> uuid? src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/14043/#comment50770> ids please. src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/14043/#comment50771> uuid? src/slave/cgroups_isolator.cpp <https://reviews.apache.org/r/14043/#comment50766> s/Threat/Treat/ - Vinod Kone On Sept. 9, 2013, 11:57 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14043/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2013, 11:57 p.m.) > > > Review request for mesos, Benjamin Hindman, Eric Biederman, Ian Downes, David > Mackey, and Vinod Kone. > > > Bugs: MESOS-662 > https://issues.apache.org/jira/browse/MESOS-662 > > > Repository: mesos-git > > > Description > ------- > > This adds onto tdmackey's patch here: https://reviews.apache.org/r/14024/ > > In addition to having the OOM killer enabled, this adds memory threshold > notifications in order to induce our own OOMs upon reaching the requested > memory limit. This allows us to capture the relevant memory.stat information > at the time of the OOM event for the majority of OOMs. > > When a process is allocating quickly enough to hit the hard limit, this will > still behave correctly by allowing the OOM killer to correct the OOM. In this > case, we will report memory information that excludes the offending process, > but that's the best we can do for now. > > > Diffs > ----- > > src/slave/cgroups_isolator.hpp e86062e9abaaa263c32c55e9dbfefd700f605886 > src/slave/cgroups_isolator.cpp a1f5b32ee9c67e418c2c4ad496fa1bf97dc1ae76 > src/slave/flags.hpp ea1e4f7b7c6a5923ca94921299197a0037a40b4f > > Diff: https://reviews.apache.org/r/14043/diff/ > > > Testing > ------- > > make check, added tests in https://reviews.apache.org/r/14044 > > > Thanks, > > Ben Mahler > >
