----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14072/#review26027 -----------------------------------------------------------
Ship it! Thanks Ben! 3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp <https://reviews.apache.org/r/14072/#comment50828> I think I'm more partial to calling this Memory to just capture the memory that we're copying in shared memory (and the fact that we have a 'set' field) and to not confuse it with the missing bits from os::Process. 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp <https://reviews.apache.org/r/14072/#comment50827> Any reason not to do the constants first? I think that's convention both in gtest and in our tests. 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp <https://reviews.apache.org/r/14072/#comment50825> Same here. 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp <https://reviews.apache.org/r/14072/#comment50826> Same here. - Benjamin Hindman On Sept. 10, 2013, 10:38 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14072/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2013, 10:38 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Bugs: MESOS-641 > https://issues.apache.org/jira/browse/MESOS-641 > > > Repository: mesos-git > > > Description > ------- > > This fixes the Fork issues by storing a Process struct in shared memory > rather than simply just a pid. > > Previously we would attempt to construct the process tree using the pids from > shared memory. This can lead to issues if some of the processes have exited > by the time we attempt to construct the tree. Rather than storing the pids, > this stored the necessary process related information in a struct. > > Also, I've updated the test expectations to handle shells that fork/exec > commands when run with "sh -c". > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/fork.hpp > 64e3b5d211aae9120f8854397b07266e6cfe08ea > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 0ef2eb5b95b76a5837b98854b09bedfb43f0e5eb > > Diff: https://reviews.apache.org/r/14072/diff/ > > > Testing > ------- > > make check on OSX, Ubuntu 10.04 and CentOS 5.9 > > > Thanks, > > Ben Mahler > >
