----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11974/#review26100 -----------------------------------------------------------
Ship it! Can you update the comment with the fact that 1.54 also doesn't compile? :( Just curious, was this the only obstacle to compiling with gcc 4.8? Otherwise maybe it's best to bundle all the needed fixes in one review? - Ben Mahler On June 26, 2013, 8:42 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11974/ > ----------------------------------------------------------- > > (Updated June 26, 2013, 8:42 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > ------- > > Fix broken build on GCC 4.8 due to -Wall. > > With GCC 4.8, Boost fails to build from '-Wunused-local-typedefs', which > is implied by '-Wall'. > > Review: https://reviews.apache.org/r/11974/ > > > Diffs > ----- > > configure.ac fbe22e5772502ef3d9bea7b58b323881a51934ab > > Diff: https://reviews.apache.org/r/11974/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Brenden Matthews > >
