> On Sept. 13, 2013, 8:57 p.m., Ben Mahler wrote: > > How about: "Slave offline"?
I like it. "Slave offline" is a better description. I updated the diff with the new text. Good to ship? - Ross ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14074/#review26097 ----------------------------------------------------------- On Sept. 13, 2013, 11:18 p.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14074/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2013, 11:18 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-650 > https://issues.apache.org/jira/browse/MESOS-650 > > > Repository: mesos-git > > > Description > ------- > > Hid links to dead slaves to prevent dead links. > > If a slave is gone, the framework page will print "Slave gone" in place > of the links to the slave's UI. The links would previously fail in > redirection and return the user to the Mesos root page, which is > unpleasant. > > Fixes: https://issues.apache.org/jira/browse/MESOS-650 > > Review: http://reviews.apache.org/r/14074 > > > Diffs > ----- > > src/webui/master/static/framework.html > 1973cbed6759d0f007816377319a17c7e91a182d > > Diff: https://reviews.apache.org/r/14074/diff/ > > > Testing > ------- > > Ran tasks on a slave, killed the slave, and rendered the framework page. The > links were replaced with "Slave gone". > > > Thanks, > > Ross Allen > >
