> On Sept. 17, 2013, 12:55 a.m., Vinod Kone wrote: > > configure.ac, line 217 > > <https://reviews.apache.org/r/14164/diff/1/?file=352499#file352499line217> > > > > This is missing a ";;" here. > > Vinod Kone wrote: > Also confirmed that the patch works with gcc 4.2 on osx and linux (after > the semicolons fix ofcourse :)).
Weird. The missing semicolons fell off the face of the earth: https://github.com/airbnb/mesos/commit/3adfe752cc7b9798c5ae52edb2d38fec24d82ae1#L0R225 - Brenden ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14164/#review26161 ----------------------------------------------------------- On Sept. 16, 2013, 10:09 p.m., Brenden Matthews wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14164/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2013, 10:09 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-688 > https://issues.apache.org/jira/browse/MESOS-688 > > > Repository: mesos-git > > > Description > ------- > > Fixed build breakage from 37e946683f1bb6a. > > In 37e946683f1bb6a I fixed a build failure from a warning, which are > treated as errors. > > Newer versions of GCC have a feature (documented here: > http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html) where unknown > warning flags are ignored. > > In older version of GCC (such as 4.1 or 4.2), it appears that these flags > aren't ignored, resulting in an error. > > Review: https://reviews.apache.org/r/14164 > > > Diffs > ----- > > configure.ac 73baf034972549ff34ac1c8f7c098fb3a34baf4e > > Diff: https://reviews.apache.org/r/14164/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Brenden Matthews > >
