-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14309/#review26358
-----------------------------------------------------------



3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
<https://reviews.apache.org/r/14309/#comment51445>

    Also, shouldn't this only assign h_errnop when the call fails?
    
    i.e.
    
    if (*(result) == NULL && h_errnop != NULL) { ... }


- Ben Mahler


On Sept. 24, 2013, 6:03 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14309/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2013, 6:03 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 728122ec9eeb903723daa9294e258fed2141bea6 
> 
> Diff: https://reviews.apache.org/r/14309/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Reply via email to