> On Sept. 20, 2013, 2:55 a.m., Ben Mahler wrote: > > src/tests/isolator.hpp, lines 100-104 > > <https://reviews.apache.org/r/14097/diff/1/?file=351099#file351099line100> > > > > Consider logging this explicitly when the framework id is different and > > the executor id is the same (to avoid potential confusion later).
logged the framework id. we don't store the framework ids, so we can't tell if it was previously launched by the same framework or different. > On Sept. 20, 2013, 2:55 a.m., Ben Mahler wrote: > > src/tests/master_tests.cpp, line 465 > > <https://reviews.apache.org/r/14097/diff/1/?file=351100#file351100line465> > > > > Why the s/executorInfo.executor_id()/DEFAULT_EXECUTOR_ID/ change here? good catch. fixed. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14097/#review26291 ----------------------------------------------------------- On Sept. 12, 2013, 1:52 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14097/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2013, 1:52 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-467 and MESOS-686 > https://issues.apache.org/jira/browse/MESOS-467 > https://issues.apache.org/jira/browse/MESOS-686 > > > Repository: mesos-git > > > Description > ------- > > TestingIsolator now rejects launching of multiple executors with same > ExecutorID. This means 2 different frameworks cannot used the same executor > id. While this is a restriction it is better than changing all tests to grab > the framework id before creating testing isolator. > > Also fixed tests that were incorrectly launching multiple executors. > > > Diffs > ----- > > src/launcher/launcher.cpp 6f2677a5e04871fa09ca3d0a926e1474eff609c7 > src/tests/allocator_tests.cpp c57da6eb3c431b47468b6a6941c3de06af9209e5 > src/tests/allocator_zookeeper_tests.cpp > 6e3214c15c14dc8ba82082738c172c8833cd0887 > src/tests/fault_tolerance_tests.cpp > 10e52c401476eb8416361de49b8e4061bb7ac4f3 > src/tests/gc_tests.cpp e404de3bfacfcac5515995f1b45c3d39181e138f > src/tests/isolator.hpp fe6b38d4f31f7a8cb901c37c0d153f4ddc08c923 > src/tests/master_tests.cpp 52f09d4f1ddeabcc1a797a13fae9641b72425dd5 > src/tests/mesos.hpp 8fbd56c8dd438a08673b54630bfe25d60ad5ee0e > > Diff: https://reviews.apache.org/r/14097/diff/ > > > Testing > ------- > > make check > > sudo ./bin/mesos-tests.sh --gtest_filter="*FrameworkExited*" > --gtest_repeat=1000 --gtest_break_on_failure --gtest_shuffle > > sudo ./bin/mesos-tests.sh --gtest_filter="*GarbageCollectorIntegrationTest*" > --gtest_repeat=1000 --gtest_break_on_failure --gtest_shuffle > > > Thanks, > > Vinod Kone > >
