> On Sept. 19, 2013, 8:50 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 456 > > <https://reviews.apache.org/r/14098/diff/1/?file=351123#file351123line456> > > > > Can you just use .keys()? > > > > > > // The keys must be copied because they are removed in > > shutdownFramework(). > > foreach (const FrameworkID& frameworkId, frameworks.keys()) {
done. thanks. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14098/#review26285 ----------------------------------------------------------- On Sept. 12, 2013, 3:35 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14098/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2013, 3:35 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-690 > https://issues.apache.org/jira/browse/MESOS-690 > > > Repository: mesos-git > > > Description > ------- > > Need to copy 'frameworks' when looping through them and shutting them down > because shutdownFramework() can mutate 'frameworks'. > > > Diffs > ----- > > src/slave/slave.cpp cefb42004da15d390c276ad5337b558ba5bf8e59 > > Diff: https://reviews.apache.org/r/14098/diff/ > > > Testing > ------- > > make check > > ./bin/mesos-tests.sh --gtest_filter="*FaultToleranceTest*" > --gtest_repeat=1000 --gtest_break_on_failure --gtest_shuffle > > > Thanks, > > Vinod Kone > >
