> On Sept. 27, 2013, 1:22 a.m., Ben Mahler wrote: > > We typically avoid modifying third party source as much as possible, and if > > we do it's done through patches so that: > > > > 1. It's clear what has been modified. > > 2. It can be repeated when we upgrade (although in this case maybe that's > > not applicable?) > > > > Can benefit from the combined css when we upgrade to v3 instead?
I renamed the final version "bootstrap-combined-2.3.2.min.css" for this reason. Ideally there would be a build step to do this combination. If this is too confusing, I can drop this change and look into a proper build step for assets. - Ross ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14348/#review26429 ----------------------------------------------------------- On Sept. 26, 2013, 4:48 p.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14348/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2013, 4:48 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Combined responsive Bootstrap styles into core file. > > Both the core and the responsive Bootstrap styles are always used, and > so there is no benefit in keeping them as separate files. Combining > them saves an HTTP request. > > Bootstrap v3 does not separate core- and responsive styles either. This > is the future. > > Review: http://reviews.apache.org/r/14348 > > > Diffs > ----- > > src/webui/master/static/css/bootstrap-2.3.2.min.css > b6428e695860151f82076e87810fe2d133339c2a > src/webui/master/static/css/bootstrap-responsive-2.3.2.min.css > f4ede63f32e2ec803876a38efac05dd49acc4684 > src/webui/master/static/index.html ce504aac56a7fd921d71a09b76050c75bf203be2 > > Diff: https://reviews.apache.org/r/14348/diff/ > > > Testing > ------- > > > Thanks, > > Ross Allen > >
