----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14400/#review26577 -----------------------------------------------------------
Ship it! TODO for UPID to use HostPort and kill the duplicated code? 3rdparty/libprocess/include/process/hostport.hpp <https://reviews.apache.org/r/14400/#comment51821> Looks like this is not needed? (I see your hash_value comment but that function should not require this to be included). - Ben Mahler On Oct. 1, 2013, 7:43 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14400/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2013, 7:43 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 130d40c3301bc6ffa6d8e531e48d8d9406a61cf7 > 3rdparty/libprocess/include/process/hostport.hpp PRE-CREATION > 3rdparty/libprocess/include/process/pid.hpp > 5a77dbc7b6917552536c936d1cc5791f24323bb7 > 3rdparty/libprocess/src/pid.cpp 81c2b2b922678fc40858d3c6696b1893c9215710 > 3rdparty/libprocess/src/tests/hostport_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/14400/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
