----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14431/#review26584 -----------------------------------------------------------
Ship it! src/tests/allocator_tests.cpp <https://reviews.apache.org/r/14431/#comment51825> Can you actually test that the sum of the resources in these 2 calls is equal to the sum of task and executor resources? Future<Nothing> resourceOffers1; Future<Nothing> resourceOffers2; EXPECT_CALL(sched, resourceOffers(_,_) .WillOnce(FutureSatisfy(&resourceOffers1) .WillOnce(FutureSatisfy(&resourceOffers2)); AWAIT_READY(resourceOffers1); AWAIT_READY(resourceOffers2); ASSERT_EQ(resourceOffers1.get() + resourceOffers2.get(), expected) - Vinod Kone On Oct. 2, 2013, 12:19 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14431/ > ----------------------------------------------------------- > > (Updated Oct. 2, 2013, 12:19 a.m.) > > > Review request for mesos, Benjamin Hindman, Thomas Marshall, and Vinod Kone. > > > Bugs: MESOS-621 > https://issues.apache.org/jira/browse/MESOS-621 > > > Repository: mesos-git > > > Description > ------- > > I noticed this bug described in Thomas' comment in MESOS-621, so I figured I > would fix it along the way to MESOS-711. > > The recovery of executor resources upon slave removal was missing. > > > Diffs > ----- > > src/master/master.cpp a49b17ef43fca5b385a89731ca8776a26b61399a > src/tests/allocator_tests.cpp c57da6eb3c431b47468b6a6941c3de06af9209e5 > > Diff: https://reviews.apache.org/r/14431/diff/ > > > Testing > ------- > > make check and updated a test to reflect the change > > > Thanks, > > Ben Mahler > >
